8000 Move climate intent to homeassistant integration by synesthesiam · Pull Request #139371 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Move climate intent to homeassistant integration #139371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 28, 2025
Merged

Move climate intent to homeassistant integration #139371

merged 3 commits into from
Feb 28, 2025

Conversation

synesthesiam
Copy link
Contributor
@synesthesiam synesthesiam commented Feb 26, 2025 •
edited
Loading

Breaking change

Proposed change

In preparation for #139221 this PR moves the HassClimateGetTemperature intent to the intent integration.

This is needed because the intent will straddle both the climate and sensor integrations (when #139221 is updated and merged) since the current temperature of an area can come from a sensor or a thermostat.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@synesthesiam synesthesiam marked this pull request as ready for review February 26, 2025 16:56
@synesthesiam synesthesiam requested a review from a team as a code owner February 26, 2025 16:56
@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (climate) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of climate can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign climate Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (homeassistant) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of homeassistant can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign homeassistant Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@synesthesiam synesthesiam mentioned this pull request Feb 26, 2025
Merged
19 tasks
@synesthesiam synesthesiam marked this pull request as draft February 26, 2025 18:20
@synesthesiam synesthesiam force-pushed the synesthesiam-20250226-move-get-temperature branch from 45a3305 to 6b6e788 Compare February 27, 2025 16:15
@synesthesiam synesthesiam marked this pull request as ready for review February 27, 2025 16:17
@synesthesiam synesthesiam added this to the 2025.3.0 milestone Feb 27, 2025
@abmantis
Copy link
Member

If the intent is going to be used for non-climate entities, should it e renamed to HassGetTemperature instead?

@synesthesiam
Copy link
Contributor Author

Technically yes, but then we will have breaking changes in a lot of places.

@balloob balloob merged commit fca19a3 into dev Feb 28, 2025
46 checks passed
@balloob balloob deleted the synesthesiam-20250226-move-get-temperature branch February 28, 2025 15:25
bramkragten pushed a commit that referenced this pull request Feb 28, 2025
@synesthesiam @bramkragten
Move climate intent to homeassistant integration (#139371)
0891669 
* Move climate intent to homeassistant integration

* Move get temperature intent to intent integration

* Clean up old test
@github-actions github-actions bot locked and limited conversation to collaborators Mar 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
cherry-picked cla-signed code-quality core has-tests integration: climate integration: homeassistant Quality Scale: internal
Projects
None yet
Milestone
2025.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@synesthesiam @abmantis @balloob @bramkragten
0