8000 Bump Music Assistant client to 1.1.1 by marcelveldt · Pull Request #139331 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

8000 Bump Music Assistant client to 1.1.1 #139331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 26, 2025
Merged

Bump Music Assistant client to 1.1.1 #139331

merged 6 commits into from
Feb 26, 2025

Conversation

marcelveldt
Copy link
Member
@marcelveldt marcelveldt commented Feb 26, 2025 •
edited
Loading

Proposed change

Bump the Music Assistant client to 1.1.1
The new client contains compatibility with the new features added in Music Assistant 2.4

Changelog: music-assistant/client@1.0.8...1.1.1

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @music-assistant, mind taking a look at this pull request as it has been labeled with an integration (music_assistant) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of music_assistant can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign music_assistant Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@marcelveldt marcelveldt added this to the 2025.3.0b0 milestone Feb 26, 2025
edenhaus
edenhaus requested changes Feb 26, 2025
View reviewed changes
Copy link
Member
@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bumping the dependency! However, could you please update the PR description to contain at least one (or multiple) of the following:

  • A link to the release notes of this package version, and all versions in between.
  • A link to the changelog of this package.
  • A link to a Git(Hub) diff/compare view from the current version to the bumped version.

This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.

Thanks already! 👍

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft February 26, 2025 10:48
@marcelveldt marcelveldt marked this pull request as ready for review February 26, 2025 10:50
@home-assistant home-assistant bot requested a review from edenhaus February 26, 2025 10:50
@edenhaus edenhaus marked this pull request as draft February 26, 2025 11:01
@marcelveldt marcelveldt marked this pull request as ready for review February 26, 2025 11:08
joostlek
joostlek requested changes Feb 26, 2025
View reviewed changes
Copy link
Member
@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The library has its py.typed setup wrong and thus mypy can't read the types

@home-assistant home-assistant bot marked this pull request as draft February 26, 2025 11:55
@marcelveldt marcelveldt changed the title Bump Music Assistant client to 1.1.0 Bump Music Assistant client to 1.1.1 Feb 26, 2025
@marcelveldt
Copy link
Member Author

Bumped to 1.1.1 to fix the missing py.typed

@marcelveldt marcelveldt marked this pull request as ready for review February 26, 2025 12:43
@home-assistant home-assistant bot requested a review from joostlek February 26, 2025 12:43
@marcelveldt marcelveldt mentioned this pull request Feb 26, 2025
Merged
19 tasks
@frenck frenck merged commit bb9aba2 into dev Feb 26, 2025
46 checks passed
@frenck frenck deleted the bump-music-assistant-client-to-1.1.0 branch February 26, 2025 13:48
@github-actions github-actions bot locked and limited conversation to collaborators Feb 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joostlek joostlek joostlek approved these changes

@edenhaus edenhaus Awaiting requested review from edenhaus

Assignees
No one assigned
Labels
cla-signed dependency integration: music_assistant Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2025.3.0b0
Development

Successfully merging this pull request may close these issues.
4 participants
@marcelveldt @joostlek @edenhaus @frenck
0