Add current cavity temperature sensor to Home Connect #139282
Conversation
|
Hey there @DavidMStraub, @MartinHjelmare, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
| key=StatusKey.COOKING_OVEN_CURRENT_CAVITY_TEMPERATURE, | ||
| device_class=SensorDeviceClass.TEMPERATURE, | ||
| state_class=SensorStateClass.MEASUREMENT, | ||
| translation_key="current_cavity_temperature", |
There was a problem hiding this comment.
Where's the unit of measurement set? I don't see a translation and there's no native unit set that I can find.
There was a problem hiding this comment.
translation is here:
core/homeassistant/components/home_connect/strings.json
Lines 1532 to 1534 in 8c34eb5
Native unit is something we should fetch from the API but we can set a default one by the moment
There was a problem hiding this comment.
Ok. I was thinking about a unit translation which is the other option if a native unit of measurement isn't set.
There was a problem hiding this comment.
Indeed, I missed the missing unit! 🙃
Can you please open a new PR adding it @Diegorro98 ?
|
When creating a follow-up PR please also consider renaming that entity: I see in sensor.py that it comes from COOKING_OVEN_CURRENT_CAVITY_TEMPERATURE So please add "oven" so we get correct translations. |
|
Requested changes done at #139355 |
Proposed change
Add current cavity temperature sensor to Home Connect integration
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: