8000 Make Radarr units translatable by danbishop · Pull Request #139250 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Make Radarr units translatable #139250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 25, 2025
Merged

Make Radarr units translatable #139250

merged 6 commits into from
Feb 25, 2025

Conversation

danbishop
Copy link
Contributor
@danbishop danbishop commented Feb 25, 2025 •
edited
Loading

Proposed change

Make units in the Radarr integration translatable.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

None

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @tkdrob, mind taking a look at this pull request as it has been labeled with an integration (radarr) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of radarr can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign radarr Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

joostlek
joostlek requested changes Feb 25, 2025
View reviewed changes
@home-assistant home-assistant bot marked this pull request as draft February 25, 2025 12:47
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

danbishop
danbishop commented Feb 25, 2025
View reviewed changes
Copy link
Contributor Author
@danbishop danbishop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is better 👍

@danbishop danbishop marked this pull request as ready for review February 25, 2025 12:57
@home-assistant home-assistant bot requested a review from joostlek February 25, 2025 12:57
@joostlek
Copy link
Member
8000 joostlek commented Feb 25, 2025

fyi, you havent pushed yet

joostlek
joostlek reviewed Feb 25, 2025
View reviewed changes
joostlek
joostlek reviewed Feb 25, 2025
View reviewed changes
@danbishop danbishop requested a review from joostlek February 25, 2025 13:11
@joostlek joostlek merged commit d45fce8 into home-assistant:dev Feb 25, 2025
32 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joostlek joostlek joostlek approved these changes

Assignees
No one assigned
Labels
cla-signed code-quality integration: radarr Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danbishop @joostlek
0