8000 Add update reward action to Habitica integration by tr4nt0r · Pull Request #139157 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add update reward action to Habitica integration #139157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 25, 2025
Merged

Add update reward action to Habitica integration #139157

merged 2 commits into from
Feb 25, 2025

Conversation

tr4nt0r
Copy link
Contributor
@tr4nt0r tr4nt0r commented Feb 24, 2025 •
edited
Loading

Proposed change

Adds an action to update a reward. This is the first of various planned PRs, as there are 4 different types of tasks, each will get an update and a create action.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@tr4nt0r tr4nt0r mentioned this pull request Feb 24, 2025
Closed
19 tasks
NoRi2909
NoRi2909 reviewed Feb 24, 2025
View reviewed changes
@tr4nt0r tr4nt0r mentioned this pull request Feb 24, 2025
Merged
8 tasks
@tr4nt0r tr4nt0r requested a review from NoRi2909 February 24, 2025 18:30
@joostlek joostlek merged commit 2509353 into home-assistant:dev Feb 25, 2025
32 checks passed
@tr4nt0r tr4nt0r deleted the habitica_create_reward branch February 25, 2025 12:56
@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joostlek joostlek joostlek approved these changes

@NoRi2909 NoRi2909 Awaiting requested review from NoRi2909

Assignees
No one assigned
Labels
by-code-owner cla-signed has-tests integration: habitica new-feature Quality Scale: platinum
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tr4nt0r @joostlek @NoRi2909
0