8000 Add common state translation string for charging and discharging by mib1185 · Pull Request #139074 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add common state translation string for charging and discharging #139074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2025
Merged

Add common state translation string for charging and discharging #139074

merged 1 commit into from
Feb 25, 2025

Conversation

mib1185
Copy link
Contributor
@mib1185 mib1185 commented Feb 22, 2025

Proposed change

SSIA

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

starkillerOG
starkillerOG approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor
@starkillerOG starkillerOG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mib1185 mib1185 added this to the 2025.3.0b0 milestone Feb 25, 2025
MartinHjelmare
MartinHjelmare approved these changes Feb 25, 2025
View reviewed changes
@MartinHjelmare MartinHjelmare merged commit ef46552 into dev Feb 25, 2025
45 checks passed
@MartinHjelmare MartinHjelmare deleted the common_strings/charging-and-discharging branch February 25, 2025 19:03
@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

@CloCkWeRX CloCkWeRX CloCkWeRX approved these changes

@starkillerOG starkillerOG starkillerOG approved these changes

@allenporter allenporter Awaiting requested review from allenporter allenporter is a code owner

@frenck frenck Awaiting requested review from frenck frenck is a code owner

@bdraco bdraco Awaiting requested review from bdraco bdraco is a code owner

@cgarwood cgarwood Awaiting requested review from cgarwood cgarwood is a code owner

@joostlek joostlek Awaiting requested review from joostlek joostlek is a code owner

Assignees
No one assigned
Labels
cla-signed code-quality core small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2025.3.0b0
Development

Successfully merging this pull request may close these issues.
4 participants
@mib1185 @CloCkWeRX @MartinHjelmare @starkillerOG
0