8000
Improve failure handling and logging for invalid map responses #139681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @Lash-L, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Lash-L
reviewed
Mar 3, 2025
Comment on lines
+54
to
+58
| try: | ||
| parsed_map = parser.parse(map_bytes) | ||
| except (IndexError, ValueError) as err: | ||
| _LOGGER.debug("Exception when parsing map contents: %s", err) | ||
| return None |
There was a problem hiding this comment.
So iirc the problem here is that map_bytes was getting passed in as None typically do to a timeout or some other issue that was causing issues. This is at the very least a good thing to do to help prevent errors
There was a problem hiding this comment.
My impression is that when map_bytes is None then we'd get a different error:
>>> a = None
>>> a[2]
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
TypeError: 'NoneType' object is not subscriptable
But we get an IndexError:
>>> a[2]
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
IndexError: string index out of range
I think we already check for the empty string somewhere, so is it a single character getting returned? We'll see soon...
Lash-L
approved these changes
Mar 3, 2025
frenck
approved these changes
Mar 3, 2025
frenck
pushed a commit
that referenced
this pull request
Mar 4, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Improve failure handling and logging for invalid map responses by catching exceptions and logging debug details about the image bytes.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: