8000 Still request scopes in SmartThings by joostlek · Pull Request #139626 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Still request scopes in SmartThings #139626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 2, 2025
Merged

Still request scopes in SmartThings #139626

merged 1 commit into from
Mar 2, 2025

Conversation

joostlek
Copy link
Member
@joostlek joostlek commented Mar 2, 2025

Proposed change

Still request scopes in SmartThings as I checked with the SmartThing theme. Even though we don't get the scopes back, we should still request them.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@joostlek joostlek added this to the 2025.3.0 milestone Mar 2, 2025
@CloCkWeRX
Copy link
Contributor

Elsewhere it is doing:

        if data[CONF_TOKEN]["scope"].split() != SCOPES:
            return self.async_abort(reason="missing_scopes")

Does this check need to also be aware of this or at least changed to you have included at least the content of SCOPES plus more? Not obvious at first glance

@joostlek
Copy link
Member Author
joostlek commented Mar 2, 2025

Yea, that is the list of scopes we get back. Apparently we are allowed to request all, but we don't get everything back. Yesterday I added a PR to not request it, but the SmartThings team recommended to still request it.

@frenck frenck merged commit 3eadfcc into home-assistant:dev Mar 2, 2025
32 checks passed
@joostlek joostlek deleted the st-scopes-2 branch March 2, 2025 13:23
bramkragten pushed a commit that referenced this pull request Mar 2, 2025
@joostlek @bramkragten
Still request scopes in SmartThings (#139626)
1d0cba1 
Still request scopes
@github-actions github-actions bot locked and limited conversation to collaborators Mar 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thecode thecode thecode approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed has-tests integration: smartthings Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2025.3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@joostlek @CloCkWeRX @thecode @frenck @bramkragten
0