8000 Don't split wheels builder anymore #139522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No need to wait for all the test jobs as I changed only the wheels workflow |
bramkragten
pushed a commit
that referenced
this pull request
Feb 28, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
During the analysis of the failed run https://github.com/home-assistant/core/actions/runs/13585262518, @joostlek and I found out the that even if we have pinned
slixmppto1.8.5,aioharmony==0.4.1requiresslixmpp>1.8. Due to the fact that we are splitting the wheels building into three parts andaioharmonyis in the first part andslixmppis in the last. The pinning will not take effect, and Pip will install and build the wheels for the latestslixmpp.slixmpp 1.9.0was released yesterday and includes the first version with rust code, which requires at least rust 1.81 to build the wheels.To avoid unnecessary wheels and also make sure all pinned versions are used correctly, I removed the splitting of the wheels builder. A test run https://github.com/home-assistant/core/actions/runs/13588424145 was green, and therefore the memory issue is solved in the meantime
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: