8000 Improve error handling in CoreBackupReaderWriter by emontnemery · Pull Request #139508 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improve error handling in CoreBackupReaderWriter #139508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2025
Merged

Improve error handling in CoreBackupReaderWriter #139508

merged 1 commit into from
Feb 28, 2025

Conversation

emontnemery
Copy link
Contributor

Proposed change

Improve error handling in CoreBackupReaderWriter:

CoreBackupReaderWriter unconditionally calls BackupManager.async_post_backup_actions. If that fails, we wrap any unhandled error and the error raised by BackupManager.async_post_backup_actions so the caller sees both errors.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@emontnemery emontnemery added this to the 2025.3.0 milestone Feb 28, 2025
@emontnemery emontnemery requested a review from a team as a code owner February 28, 2025 10:59
@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (backup) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of backup can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign backup Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@emontnemery
Copy link
Contributor Author

Tagging for 2025.3.0 because the improved error handling is meant to aid debugging issues

@frenck frenck merged commit 228a4eb into dev Feb 28, 2025
46 checks passed
@frenck frenck deleted the backup_writer_improve_post_backup_error_handling branch February 28, 2025 13:25
bramkragten pushed a commit that referenced this pull request Feb 28, 2025
@emontnemery @bramkragten
Improve error handling in CoreBackupReaderWriter (#139508)
4300900
@github-actions github-actions bot locked and limited conversation to collaborators Mar 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
by-code-owner cherry-picked cla-signed code-quality has-tests integration: backup Quality Scale: internal small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2025.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@emontnemery @frenck @bramkragten
0