Fix update data for multiple Gree devices #139469
Conversation
do not use handler for explicit update devices as internal communication lib do not provide which device is updated use ha update loop copy data object to prevent rewrite data from internal lib allow more time to process response before log warning about long wait for response and make log message more clear
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Hey there @cmroche, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
thanks @frenck, can you also cherry pick into a point release please |
There is no point release in this cycle anymore. We do have a beta running, however, this PR didn't solve any bugs as per pull request description. It only listed affiliation with some of them? Since the beta is already in freeze, we only pick bug fixes at this point. ../Frenck |
|
but if this version is in freeze then it will be released soon so i thing we can wait little more :) any way thanks for review |
Breaking change
Proposed change
problem
Main problem is if you have multiple devices only 1 device is updated in refresh loop
when update response is process for any device it postpone update for all devices
changes
Do not use explicit update handler for devices status update, internal communication lib (now) do not provide which device is updated
use HA refresh loop to update data of device
copy data object to prevent rewrite data from internal lib and make DataUpdateCoordinator update data only if changed
#128046
#124007
allow more time to process response before log warning about long wait for response and make log message more clear
#131645
#127008
also im new to HA this is my 1. pr
i test it locally with 2 gree AC now they are updated fine, i can change ac with controller or gree app and HA is correctly updated
PS there is another issue KeyError: 'val'
#128046 (comment)
this need to be solved in internal greeclimate project there is PR for it cmroche/greeclimate#110
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: