8000 Change touchline dependency to pytouchline_extended #136362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joostlek As promised a PR where i only change the dependency |
joostlek
requested changes
Jan 23, 2025
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Please also add an explanation on why we switch and a link to the new library |
19 tasks
I removed the unused properties and added a bit more docs. Referenced the new PR with the config flow and other changes |
|
Oh this PR wasn't ready for review yet |
joostlek
approved these changes
Feb 25, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Type of change
Additional information
Changed from the unmaintained pytouchline module to pytouchline_extended, which support multiple roth touchline controllers and just general maintained dependencies. (dependabot and a release pipeline is enabled on the repo as well).
The old dependency is only there for historic reasons: abondoe/pytouchline#9
I created the new dependency to pass a
unique idfor each device allowing home assistant to assign it to areas etc. and most important to myself is the ability to add multiple controllers in the same home assistant installationYou can checkout the new touchline module here: https://github.com/brondum/pytouchline
I would recommend doing both this and the config flow pr #136473
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: