Fix limitlessled color temperature #12971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please have a look at issue : #12976 |
|
Please do not pollute everywhere trying to get attention. |
|
Ok sorry, just tried to help to improve things and report issues.
|
|
Can you add a breaking change paragraph to the PR description. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change description:
The LimitlessLED white temperature range has been adjusted and should now match the Mi-Light smartphone app for identical Kelvin values.
Description:
According to the developer documentation and the UI in the smartphone app, the LimitlessLED temperature range is 2700K-6500K.
This issue was reported in the forums. I am a bit afraid that it will not apply to all lights (and cause another breaking change) but so far I found no indication of that.
Update: testing the corrected range revealed that the conversion function was actually also wrong. I have changed that in a followup commit.
Checklist:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully.