8000 Fixed Pollen.com bugs with ZIP codes and invalid API responses by bachya · Pull Request #12790 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fixed Pollen.com bugs 8000 with ZIP codes and invalid API responses #12790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2018
Merged

Fixed Pollen.com bugs with ZIP codes and invalid API responses #12790

merged 1 commit into from
Feb 28, 2018

Conversation

bachya
Copy link
Contributor
@bachya bachya commented Feb 28, 2018

Description:

  1. Fixes a bug wherein ZIP codes starting with 0 would fail.
  2. Adds some guards against bad API calls.

Related issue (if applicable): fixes #12787

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#4784

Example entry for configuration.yaml (if applicable):

sensor:
- platform: pollen
  zip_code: "00544"
  monitored_conditions:
    - allergy_average_forecasted
    - allergy_average_historical
    - allergy_index_today
    - allergy_index_tomorrow
    - allergy_index_yesterday
    - disease_average_forecasted

Checklist:

  • The code change is tested and works locally.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass

@balloob balloob merged commit a0eca9c into home-assistant:dev Feb 28, 2018
@balloob balloob added this to the 0.64.2 milestone Feb 28, 2018
@balloob
Copy link
Member
balloob commented Feb 28, 2018

Awesome 🎉

@bachya bachya deleted the pollen-updates branch March 1, 2018 00:33
balloob pushed a commit that referenced this pull request Mar 1, 2018
@bachya @balloob
Fixed Pollen.com bugs with ZIP codes and invalid API responses (#12790)
7511286
@balloob balloob mentioned this pull request Mar 1, 2018
Merged
@home-assistant home-assistant locked and limited conversation to collaborators Jul 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-signed integration: pollen small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
0.64.2
Development

Successfully merging this pull request may close these issues.

RFC: can't use ZIP codes with leading zeroes
3 participants
@bachya @balloob @homeassistant
0