Add Weatherflow Cloud wind support via websocket #125611
Conversation
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
a4c1eec to
adb270c
Compare
f5a323c to
3efdbfe
Compare
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
|
@joostlek - I think this is awaiting your review when you get around to it ... its gone stale :) |
5e99d2f to
fc7e688
Compare
|
@joostlek - can you look at this again :) |
|
@joostlek - I remind you again :) |
|
@joostlek - Pinging you AGAIN :) |
a0b270d to
5e99d2f
Compare
| if existing_entry := self.hass.config_entries.async_get_entry( | ||
| self.context["entry_id"] | ||
| ): | ||
| return self.async_update_reload_and_abort( | ||
| existing_entry, | ||
| data={CONF_API_TOKEN: api_token}, | ||
| reason="reauth_successful", | ||
| reload_even_if_entry_is_unchanged=False, | ||
| ) |
There was a problem hiding this comment.
I'm pretty sure I saw it in another integration. Is it wrong?
There was a problem hiding this comment.
It also appears the file is 100% covered by tests so I guess Its at least being tested. Hard cause I did this so long ago to remember things in my advanced age. :)
|
@joostlek - I left 2 issues unresolved as I'm waiting for feedback from you :) |
|
I remove the icon logic - as the new icon translation with ranges will soon support it! |
|
@joostlek - Any chance we can get this into the beta -> don't want to over-work you if you are too busy. But there is some people who would really really like to have the winds added. |
884fbd5 to
894c807
Compare
|
Any idea why CI is failing -> I can't duplicate this error locally I have nothing in git that differs from CI. Also I'm running |
Proposed change
Wind data is available via WebSockets via two different types of messages. There is a
rapid_windmessage that gives Speed/Direction and arrives at about a 3minute interval. There is also anobs_stmessage that gives averages over a time window.Added extended attributes to explain data source whether its REST or WebSocket
Dependency Upgrade PR
This PR has an upgraded dependency which is currently handled in: #135529
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: