Added cover group platform #12303
Added cover group platform #12303
Conversation
|
Related: #12229 |
* temp -> temperature * temp_sensor -> temperature_sensor
* Updated supported features * Updated config schema values and default values * Improved tests change temperature
* temp -> temperature * temp_sensor -> temperature_sensor
* Updated supported features * Updated config schema values and default values * Improved tests change temperature
* Async service calls
* Renamed files * Updated config schema * Updated tests
| async_add_devices( | ||
| [GroupCover(hass, config.get(CONF_NAME), | ||
| config.get(CONF_ENTITIES))]) | ||
| return True |
There was a problem hiding this comment.
Remove this. Nothing is checking this return value.
| class GroupCover(CoverDevice): | ||
| """Representation of a GroupCover.""" | ||
|
|
||
| def __init__(self, hass, name, entities): |
There was a problem hiding this comment.
Don't pass in hass. It will be set on the entity when it has been added to home assistant.
|
|
||
| def __init__(self, hass, name, entities): | ||
| """Initialize a GroupCover entity.""" | 8000||
| self._hass = hass |
| self.async_schedule_update_ha_state(True) | ||
|
|
||
| for entity_id in self.entities: | ||
| new_state = self._hass.states.get(entity_id) |
| value.discard(entity_id) | ||
| for value in self.tilts.values(): | ||
| value.discard(entity_id) | ||
| if value != set(): |
There was a problem hiding this comment.
Correct me if I'm wrong, but this seems a bit inefficient (creating a new object just to check emptiness).
if value:
...There was a problem hiding this comment.
You are right. tilt = True if value else False is even better.
|
|
||
| if old_state is None: | ||
| features = new_state.attributes[ATTR_SUPPORTED_FEATURES] | ||
| if features & 1 and features & 2: |
There was a problem hiding this comment.
I don't really like having these hard-coded values in here. 1) they might theoretically change at some point 2)
if features & (SUPPORT_OPEN | SUPPORT_CLOSE):
...Seems more descriptive to me.
There was a problem hiding this comment.
Missed these when transitioning to final commit. Thanks
| @property | ||
| def is_closed(self): | ||
| """Return if all covers in group are closed.""" | ||
| if self.covers[KEY_OPEN_CLOSE] == set(): |
There was a problem hiding this comment.
Same here: if self.covers[KEY_OPEN_CLOSE]: should (I think) also work.
There was a problem hiding this comment.
if not since I want to catch an empty set, but you ar
F438
e right.
| _LOGGER.debug("Stop covers called") | ||
| self._hass.add_job(self._hass.services.async_call( | ||
| DOMAIN, SERVICE_STOP_COVER, | ||
| {'entity_id': self.covers[KEY_STOP]})) |
There was a problem hiding this comment.
This code pretty much is the same as cover#stop_cover (though it doesn't support async calls, but that could be added). So I believe you could just write:
self.hass.add_job(cover.stop_cover, self.hass, self.covers[KEY_STOP])Same applies for other service calls in here.
|
|
||
|
|
||
| PLATFORM_SCHEMA = PLATFORM_SCHEMA.extend({ | ||
| vol.Optional(CONF_NAME, default='Group Cover'): cv.string, |
There was a problem hiding this comment.
Don't know about the code guidelines, but most schemas (apart from citybikes (well, kinda)) put their default name in a DEFAULT_NAME global variable.
|
Closed in favor of #12692 due to complexity of commits and conflicts from rebasing. |
* Added cover.group platform * Added async/await, smaller changes * Made (async_update) methods regular methods * Small improvements * Changed classname * Changes based on feedback * Service calls * update_supported_features is now a callback method * combined all 'update_attr_*' methods in 'async_update' * Small changes * Fixes * is_closed * current_position * current_tilt_position * Updated tests * Small changes 2
Description:
This component allows for easy setup of a
cover group(control serveral covers with one entity). To achieve the same with current components, it is necessary to use a combination ofcover.template,scriptsand asensor.templateas seen here https://home-assistant.io/components/cover.template/#multiple-coversBranch is rebased onto #12592.
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#4638
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests pass