Fix canary flaky test #11519
Merged
Fix canary flaky test #11519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a306f1e to
47a7830
Compare
|
Thanks @balloob for fixing this! |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The Canary sensor test was flaky (example), causing web requests after Home Assistant stopped, resulting in a timeout. After analyzing the test, it looks like the problem occurred because they would initialize the main component which would fire a discovery event for all other platforms.
After looking at the test code, no logic from the main component was needed and so I replaced it with a mock.
Test also became 0.5s faster 👍
Before:
After:
Checklist:
If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass