Simplify MQTT device triggers in automations #108309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @emontnemery, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
600074e to
c637380
Compare
emontnemery
requested changes
Jan 22, 2024
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
8 tasks
jbouwh
commented
Jan 23, 2024
emontnemery
reviewed
Jan 24, 2024
Co-authored-by: Erik Montnemery <erik@montnemery.com>
Co-authored-by: Erik Montnemery <erik@montnemery.com>
20 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
When MQTT device triggers are used in an automation the
discovery_idis no longer needed to identify an MQTT device trigger. Instead of thediscovery_ididentifier, that is based based on the config topic, now thedevice_id,typeandsubtypeare used together as unique identifier. If thediscovery_idis found in the MQTT device trigger automation config, then thediscovery_idstill will be used to identify the trigger instead, and the automation will keep working, even when the trigger has updatedtypeorsubtype, because existing triggers then will still be referenced bydiscovery_id.For new automation's an MQTT device trigger, set up from the UR will not have
discovery_idadded any more, as the use of this parameter is deprecated now. A consequence of that is that device triggers cannot updatetypeandsubtypeanymore without breaking the automation, which is no longer linked to thediscovery_id.No deprecation warnings for the use of
discovery_idare being given at this time, and users will only see the difference in YAML, not in the UI.Documentation
As this functionality is handled in the UI there is no specific documentation on how to add the MQTT trigger to a device automation in YAML. The change is not breaking because the documentation already has the following remark:
Background
The reason to change this because it makes it possible to create a blueprint based on the
device_id,typeandsubtypewithout the need to add adiscovery_id.This PR is an alternative approach for PR #107830.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: