Cleanup Xiaomi Aqara #10302
Merged
Cleanup Xiaomi Aqara #10302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balloob
commented
Nov 3, 2017
|
|
||
| if config.get(CONF_KEY) is None: | ||
| _LOGGER.warning( | ||
| 'Key is not provided for gateway %s. Controlling the gateway ' |
There was a problem hiding this comment.
Is this a warning or should we mark this config as invalid?
There was a problem hiding this comment.
It's a warning! We want to be able to use the gateway without a proper key.
There was a problem hiding this comment.
Can we connect if we don't have a key?
There was a problem hiding this comment.
Yes. We are able the receive measurements. We are unable to control an actor without a key.
There was a problem hiding this comment.
ooh nice, I didn't realise that. Very cool.
MartinHjelmare
approved these changes
Nov 3, 2017
|
I'm sorry for the mess. It was my fault! |
|
It's okay @syssi, managed to catch it in time. Please run your code next time locally 👍 |
|
Promised! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Pleas
2B9C
e check back later.
Description:
The Xiaomi Aqara component was broken by #10150. This fixes the services and cleans it up.
When opening a PR, please make sure that you run the code that you are submitting! If this would have gone out before 0.57, it would have broken for tons of users, impact our reputation and force us to spend time on doing a hot fix. That's not cool.
Bonus in this PR: gateway is optional in service schemas when the user has only 1 gateway.
Example entry for
configuration.yaml(if applicable):Checklist:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.