Fix device update / entity_id with names #10029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balloob
approved these changes
Oct 22, 2017
balloob
pushed a commit
that referenced
this pull request
Oct 22, 2017
* Fix device update * Add tests * add test for disabled warning
|
That was quick! Thanks a lot, hope this will go to a 0.56.1 👍 |
Merged
|
Thanks guys. For future reference, I assume that if an update doesn't go out right away, we can monkeypatch these files into our installations via |
|
Not in this case because it was a bug in a core part and not a built-in component. This fix has been released as 0.56.1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
With #9924 we forgeth that some device need call
updatebefore he provide thenamethat we read bygenerate_entity_id.This PR call now the update like before but care about the
PARALLEL_UPDATESsettings of the platform. We do now also protect the add device callback if the update will raise a exception we don't break the hole platform like before. I remove also the update code insideadd_entitiesand add a warning. We use this function now only inside tests and there we can't run into a deadlock and for custom component it's very hard to run into a real deadlock with new code. So we reduce a logic there.Fix: #10028
Fix: #10015
Fix: #10018
Fix: #10020
If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass