Mqtt light options to fix #9330 and #7810 #9829
Conversation
|
Don't merge this one yet - I'm looking into a possible issue reported by a tester. |
|
This is OK to merge (issue in prev comment was a user misunderstanding). |
|
|
||
| DEFAULT_BRIGHTNESS_SCALE = 255 | ||
| DEFAULT_NAME = 'MQTT Light' | ||
| DEFAULT_OPTIMISTIC = False | ||
| DEFAULT_PAYLOAD_OFF = 'OFF' | ||
| DEFAULT_PAYLOAD_ON = 'ON' | ||
| DEFAULT_WHITE_VALUE_SCALE = 255 | ||
| DEFAULT_ON_COMMAND_TYPE = "LAST" | ||
|
|
||
| VALUES_ON_COMMAND_TYPE = ["FIRST", "LAST", "BRIGHTNESS"] |
There was a problem hiding this comment.
What the advantage to use capital letters here?
There was a problem hiding this comment.
None. ON and OFF were capitalized so that's what I followed. It doesn't make a big difference if they're upper, lower, or case insensitive.
There was a problem hiding this comment.
Those are configuration setting and all those are lower case. ON and OFF are payloads.
| @@ -149,7 +156,7 @@ class MqttLight(Light): | |||
|
|
|||
| def __init__(self, name, effect_list, topic, templates, qos, | |||
| retain, payload, optimistic, brightness_scale, | |||
| white_value_scale): | |||
| white_value_scale, on_command_type='LAST'): | |||
There was a problem hiding this comment.
='LAST' is not needed, as far as I can tell. The schema validation will take care that the default is set.
There was a problem hiding this comment.
Sure - but I don't know that some other piece of code isn't calling the constructor directly. Having a default here keeps backward compatibility with any code (or test code) that might not have that argument in the calling sequence. I'm find taking it out if that's what you want...
Description:
Added an option to MQTT light to control when and if an ON command topic is published. Currently, ON is always sent after changing the light style (brightness, color, etc). This option allows the user to specify if ON should be sent before style topics, after style topics (the default to maintain current behavior), or to use the brightness topic as the ON command.
Related issue (if applicable): fixes #9330 and #7810
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#3595
Example entry for
configuration.yaml(if applicable):Example added to docs in io PR above
Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable ([example][ex-requir]).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass