8000 Add `uv_index` to AccuWeather weather entity by bieniu · Pull Request #97015 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add uv_index to AccuWeather weather entity #97015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2023
Merged

Add uv_index to AccuWeather weather entity #97015

merged 1 commit into from
Jul 22, 2023

Conversation

bieniu
Copy link
Member
@bieniu bieniu commented Jul 21, 2023

Breaking change

Proposed change

Related to #96951
Adds uv_index to the weather entity.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@bieniu
Copy link
Member Author
bieniu commented Jul 21, 2023

Converting to draft because of #96951 (comment)

@bieniu bieniu marked this pull request as draft July 21, 2023 13:18
@frenck frenck marked this pull request as ready for review July 22, 2023 15:07
@frenck
Copy link
Member
frenck commented Jul 22, 2023

It's ok, marked ready for review.

frenck
frenck approved these changes Jul 22, 2023
View reviewed changes
Copy link
Member
@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @bieniu 👍

../Frenck

@frenck frenck merged commit 5249660 into home-assistant:dev Jul 22, 2023
@bieniu bieniu deleted the accuweather-uv-index branch July 22, 2023 15:12
@github-actions github-actions bot locked and limited conversation to collaborators Jul 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
by-code-owner cla-signed has-tests integration: accuweather new-feature Quality Scale: platinum small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bieniu @frenck
0