8000 Fix zeroconf tests with cython 3 by bdraco · Pull Request #97054 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix zeroconf tests with cython 3 #97054

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 22, 2023
Merged

Fix zeroconf tests with cython 3 #97054

merged 2 commits into from
Jul 22, 2023

Conversation

bdraco
Copy link
Member
@bdraco bdraco commented Jul 22, 2023 •
edited
Loading

Proposed change

fixes python-zeroconf/python-zeroconf#1197

cython 3 was released a few days ago. It has some stronger type checks

This will prevent the CI from breaking the next time zeroconf gets rebuilt with Cython 3

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@bdraco
Fix zeroconf tests with cython 3
e5a59b6 
fixes python-zeroconf/python-zeroconf#1197

cython 3 was released a few days ago. It has some stronger
type checks
@home-assistant home-assistant bot added cla-signed core small-pr PRs with less than 30 lines. labels Jul 22, 2023
frenck
frenck approved these changes Jul 22, 2023
View reviewed changes
Copy link
Member
@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

../Frenck

cdce8p
cdce8p approved these changes Jul 22, 2023
View reviewed changes
Copy link
Member
@cdce8p cdce8p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @bdraco! I compiled zeroconf from source again (with cython==3.0) and can confirm this works now.

@bdraco bdraco marked this pull request as ready for review July 22, 2023 17:33
@bdraco bdraco merged commit f36930f into dev Jul 22, 2023
@bdraco bdraco deleted the zeroconf_test_fix branch July 22, 2023 17:33
@github-actions github-actions bot locked and limited conversation to collaborators Jul 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

@cdce8p cdce8p cdce8p approved these changes

Assignees
No one assigned
Labels
cla-signed core small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Home Assistant test issue when building from source with cython==3.0
3 participants
@bdraco @frenck @cdce8p
0