8000 Apply common entity schema for MQTT Scene by jbouwh · Pull Request #96949 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Apply common entity schema for MQTT Scene 8000 #96949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2023
Merged

Apply common entity schema for MQTT Scene #96949

merged 1 commit into from
Jul 22, 2023

Conversation

jbouwh
Copy link
Contributor
@jbouwh jbouwh commented Jul 20, 2023 •
edited
Loading

Proposed change

Appy the common entity schema for the MQTT scene entity.
This allows to set a device mapping and other generic entity settings like json_attributes to be set on a scene.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @emontnemery, mind taking a look at this pull request as it has been labeled with an integration (mqtt) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of mqtt can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign mqtt Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@jbouwh jbouwh force-pushed the mqtt-scene-device-mapping branch from 1bfb307 to b14c626 Compare July 21, 2023 17:12
@jbouwh jbouwh mentioned this pull request Jul 21, 2023
Merged
8 tasks
@jbouwh jbouwh marked this pull request as ready for review July 21, 2023 17:35
@jbouwh jbouwh requested a review from emontnemery as a code owner July 21, 2023 17:35
frenck
frenck approved these changes Jul 22, 2023
View reviewed changes
Copy link
Member
@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @jbouwh 👍

../Frenck

@frenck frenck merged commit 9a5774a into home-assistant:dev Jul 22, 2023
@jbouwh jbouwh deleted the mqtt-scene-device-mapping branch July 22, 2023 16:03
@github-actions github-actions bot locked and limited conversation to collaborators Jul 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

@emontnemery emontnemery Awaiting requested review from emontnemery emontnemery is a code owner

Assignees

@emontnemery emontnemery

Labels
by-code-owner cla-signed core has-tests integration: mqtt new-feature Quality Scale: gold small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbouwh @frenck @emontnemery
0