8000 Docker cleanup by michaelarnauts · Pull Request #8226 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Docker cleanup #8226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2017
Merged

Docker cleanup #8226

merged 1 commit into from
Jun 30, 2017

Conversation

michaelarnauts
Copy link
Contributor

Since the last Docker related cleanup, hass gained some weight again. This was mainly due to external packages that had to be compiled from source that didn't cleanup their sources after installing the binaries.

Docker-related changes:

  • Completes .dockerignore with files that aren't related for Docker. This is mainly to speed up development in Docker, since the image that dockerhub creates is usually quite clean.
  • Sync Dockerfile.dev with Dockerfile (add the uninstall of enum34 to Dockerfile.dev)
  • Add a warning in Dockerfile to also update Dockerfile.dev
  • Have the Docker dependency build-scripts use /usr/src/app/build/ for temporary build storage, and make sure this folder is cleaned up. All scripts install the binaries to a system path, so the sources can be removed.

Before these changes, the setup_docker_prereqs script added 463 MB to the image. After these changes, it adds 370 MB, so we lost 93 pounds megabytes!

Before:

$ docker history homeassistant/home-assistant | grep virtualization
<missing>           6 days ago          /bin/sh -c virtualization/Docker/setup_doc...   463MB

After:

$ docker history home-assistant  | grep virtualization
2b934453e141        22 minutes ago      /bin/sh -c virtualization/Docker/setup_doc...   370 MB

@michaelarnauts michaelarnauts requested review from emlove and balloob June 30, 2017 08:36
@balloob
Copy link
Member
balloob commented Jun 30, 2017

Awesome. Thanks! I'll try to pay better attention when I see PRs come in for Docker.

@balloob balloob merged commit a663dba into home-assistant:dev Jun 30, 2017
@balloob balloob mentioned this pull request Jul 1, 2017
Merged
dethpickle pushed a commit to dethpickle/home-assistant that referenced this pull request Aug 18, 2017
@michaelarnauts @dethpickle
Docker cleanup. (home-assistant#8226)
0afb354
@michaelarnauts michaelarnauts deleted the docker_cleanup branch September 21, 2017 14:45
@home-assistant home-assistant locked and limited conversation to collaborators Mar 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob approved these changes

@emlove emlove Awaiting requested review from emlove

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelarnauts @balloob @homeassistant
0