Do not call update() in constructor #8148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvizeli
reviewed
Jun 22, 2017
There was a problem hiding this comment.
I think this part need to be inside update and not recalc every state call... https://github.com/fabaff/home-assistant/blob/94c1358ff5b2f0a2cd08ec838ccbf0c6daebbffe/homeassistant/components/sensor/glances.py#L109-L150
|
|
||
| dev = [] | ||
| for resource in var_conf: | ||
| dev.append(GlancesSensor(rest, name, resource)) | ||
|
|
||
| add_devices(dev) | ||
| add_devices(dev, True) |
There was a problem hiding this comment.
I think that need not be True here since it was call above.
There was a problem hiding this comment.
Thanks. It would indeed lead to two calls.
balloob
reviewed
Jun 24, 2017
| @@ -170,12 +162,11 @@ def __init__(self, resource): | |||
| self._resource = resource | |||
| self.data = dict() | |||
|
|
|||
| @Throttle(MIN_TIME_BETWEEN_UPDATES) | |||
There was a problem hiding this comment.
You will still need the Throttle. Each entity will call update and thus if you have 5 entities, you will update 5 times!
balloob
reviewed
Jun 27, 2017
| @@ -25,7 +25,7 @@ | |||
| DEFAULT_NAME = 'Glances' | |||
| DEFAULT_PORT = '61208' | |||
|
|
|||
| MIN_TIME_BETWEEN_UPDATES = timedelta(seconds=60) | |||
| MIN_TIME_BETWEEN_UPDATES = timedelta(minutes=60) | |||
There was a problem hiding this comment.
Sure, should be one minute as before.
Merged
dethpickle
pushed a commit
to dethpickle/home-assistant
that referenced
this pull request
Aug 18, 2017
* Do not call update() in constructor * Move handling to update and re-add throttle * Fix indent * Fix interval
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Example entry for
configuration.yaml(if applicable):Checklist:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests pass