Fixed iTach command parsing with empty data #8104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvizeli
requested changes
Jun 20, 2017
| cmddata = cmd[CONF_DATA].strip() | ||
| if not cmddata: | ||
| cmddata = '""' | ||
| cmddatas += cmdname + "\n" + cmddata + "\n" |
There was a problem hiding this comment.
Please use cmddatas += "{}\n{}\n".format(...)
pvizeli
approved these changes
Jun 20, 2017
|
you need rebase this branch |
balloob
pushed a commit
that referenced
this pull request
Jun 21, 2017
* Fixed iTach command parsing with empty data * Switched to using format
|
Cherry-picked for 0.47.1 |
Merged
Merged
dethpickle
pushed a commit
to dethpickle/home-assistant
that referenced
this pull request
Aug 18, 2017
* Fixed iTach command parsing with empty data * Switched to using format
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes the case where an empty string would confuse any further iTach commands
Related issue (if applicable): fixes #7898
Checklist:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests pass