8000 Added 'all_plants' group and support for plant groups state. by aronsky · Pull Request #8063 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Added 'all_plants' group and support for plant groups state. 8000 #8063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 17, 2017
Merged

Added 'all_plants' group and support for plant groups state. #8063

merged 2 commits into from
Jun 17, 2017

Conversation

aronsky
Copy link
Contributor
@aronsky aronsky commented Jun 16, 2017 •
edited
Loading

Description:

Like switches, lights, and devices, plants deserve a group of their own! Here, I added the group all_plants, using EntityComponent's built-in functionality.

Additionally, I created the STATE_OK and STATE_PROBLEM states, and introduced them into the group component - so that a group of plants can show the STATE_PROBLEM state whenever one of its plants has a problem. Great for automations!

Checklist:

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@balloob balloob added this to the 0.47 milestone Jun 17, 2017
@balloob balloob merged commit 2ba6b3a into home-assistant:dev Jun 17, 2017
@balloob
Copy link
Member
balloob commented Jun 17, 2017

Cherry-picked for 0.47

balloob pushed a commit that referenced this pull request Jun 17, 2017
@aronsky @balloob
Added 'all_plants' group and support for plant groups state. (#8063)
9fc22ee 
* Added 'all_plants' group and support for plant groups state.

* Reversed the group states.
@balloob balloob mentioned this pull request Jun 17, 2017
Merged
@aronsky aronsky deleted the add-all-plants-group branch June 18, 2017 06:01
@balloob balloob mentioned this pull request Jul 1, 2017
Merged
@home-assistant home-assistant locked and limited conversation to collaborators Oct 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
cla-signed component core integration: group integration: plant
Projects
None yet
Milestone
0.47
Development

Successfully merging this pull request may close these issues.
4 participants
@aronsky @balloob @balloobbot @homeassistant
0