8000 Guard MySQL size calculation returning None by balloob · Pull Request #73331 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Guard MySQL size calculation returning None #73331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2022
Merged

Guard MySQL size calculation returning None #73331

merged 1 commit into from
Jun 10, 2022

Conversation

balloob
Copy link
Member
@balloob balloob commented Jun 10, 2022

Breaking change

Proposed change

Looks like this query result for MySQL calculating DB size can be None. This guards for it.

Fixes #73305

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@balloob balloob added this to the 2022.6.5 milestone Jun 10, 2022
@balloob balloob requested a review from a team as a code owner June 10, 2022 17:50
@probot-home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (recorder) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@balloob balloob merged commit 53b3d2e into dev Jun 10, 2022
@balloob balloob deleted the catch-total-size-not-calculating branch June 10, 2022 19:50
balloob added a commit that referenced this pull request Jun 10, 2022
@balloob
Guard MySQL size calculation returning None (#73331)
972aab3
@balloob balloob mentioned this pull request Jun 10, 2022
Merged
@bdraco bdraco mentioned this pull request Jun 11, 2022
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix cherry-picked cla-signed core integration: recorder small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2022.6.5
Development

Successfully merging this pull request may close these issues.

System Health show error for Recorder
2 participants
@balloob @homeassistant
0