8000 Fix Feedreader Atom feeds using `updated` date by d0nni3q84 · Pull Request #73208 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix Feedreader Atom feeds using updated 8000 date #73208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 8, 2022
Merged

Fix Feedreader Atom feeds using updated date #73208

merged 6 commits into from
Jun 8, 2022

Conversation

d0nni3q84
Copy link
@d0nni3q84 d0nni3q84 commented Jun 8, 2022 •
edited by MartinHjelmare
Loading

Breaking change

Proposed change

Properly support Atom feeds that use only the updated date format and resolve #73207.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@homeassistant
Copy link
Contributor

Hi @d0nni3q84,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant probot-home-assistant bot added integration: feedreader small-pr PRs with less than 30 lines. labels Jun 8, 2022
@MartinHjelmare MartinHjelmare changed the title Feedreader: Properly support Atom feeds that use only the updated d… Fix Feedreader Atom feeds using updated date Jun 8, 2022
MartinHjelmare
MartinHjelmare requested changes Jun 8, 2022
View reviewed changes
Copy link
Member
@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure that the CI buil 8000 d passes and add a test. Probably something similar to this:

core/tests/components/feedreader/test_init.py

Lines 100 to 120 in 4bc0438

async def test_feed(hass, events, feed_one_event):
"""Test simple feed with valid data."""
with patch(
"feedparser.http.get",
return_value=feed_one_event,
):
assert await async_setup_component(hass, feedreader.DOMAIN, VALID_CONFIG_2)
hass.bus.async_fire(EVENT_HOMEASSISTANT_START)
await hass.async_block_till_done()
assert len(events) == 1
assert events[0].data.title == "Title 1"
assert events[0].data.description == "Description 1"
assert events[0].data.link == "http://www.example.com/link/1"
assert events[0].data.id == "GUID 1"
assert events[0].data.published_parsed.tm_year == 2018
assert events[0].data.published_parsed.tm_mon == 4
assert events[0].data.published_parsed.tm_mday == 30
assert events[0].data.published_parsed.tm_hour == 5
assert events[0].data.published_parsed.tm_min == 10

@d0nni3q84
Copy link
Author

Thank you, @MartinHjelmare, for the feedback. Latest commit addresses failed CI and code coverage; tests passing locally.

@d0nni3q84 d0nni3q84 requested a review from MartinHjelmare June 8, 2022 15:50
MartinHjelmare
MartinHjelmare approved these changes Jun 8, 2022
View reviewed changes
Copy link
Member
@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare added this to the 2022.6.5 milestone Jun 8, 2022
@MartinHjelmare MartinHjelmare merged commit f7bd88c into home-assistant:dev Jun 8, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
cherry-picked cla-signed integration: feedreader small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2022.6.5
Development

Successfully merging this pull request may close these issues.

Feedreader Does Not Support Atom Date Format
4 participants
@d0nni3q84 @homeassistant @MartinHjelmare @balloob
0