Fix polling frequency for Starling integration #73282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This integration multiply the requests to the api by how many balance types is selected. It should be rewritten with a update coordinator, also it should not be a platform config anymore. |
elupus
approved these changes
Jun 9, 2022
|
I don't think we need to categorize this as a breaking change. The integration is already broken since the new api limits were introduced. This PR is just a fix. |
balloob
pushed a commit
that referenced
this pull request
Jun 10, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
In order to satisfy newly imposed rate limits for the Starling Bank API, the polling frequency of the integration has been reduced to every 3 minutes (previously every 30 seconds).
Proposed change
Currently, the integration is logging multiple
requests.exceptions.HTTPError: 429 Client Error: Too Many Requests for urlerrors after the daily limit has been reached.Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: