Remove sqlalchemy lambda_stmt usage from history, logbook, and statistics #73191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( |
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( |
It looks like these need a bit more time to mature per sqlalchemy/sqlalchemy#8098 (comment) so let's rip them out for now While this will make the queries slower, slower and correct is better than fast and incorrect.
|
Testing
|
3 tasks
balloob
approved these changes
Jun 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
It looks like these need a bit more time to mature upstream per
sqlalchemy/sqlalchemy#8098 (comment)
so let's rip them out any place where we need to worry
about thread safety.
There will likely be another sqlalchemy bump for
sqlalchemy/sqlalchemy#8098 in the future
as that problem seems to be more generic. Its likely that problem will
present as a raised exception failure state. All evidence suggests that
the lambdas have another undiscovered different thread safety
issue since the proposed fix there didn't solve the inconsistencies with the lambdas.
I left them in purge and the recorder thread because the problems
are thread safety issues and these queries are always single threaded
and I didn't want to risk causing a regression of #71015
While this will make the queries slower, slower and correct
is better than fast and incorrect.
Likely fixes #65499
Likely fixes #70011
Fixes #73155
Fixes #72991
Fixes #73154
Fixes #73108
Fixes Limych/ha-average#139
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: