Use default 8000 None for voltage property of FritzDevice in Fritz!Smarthome #73141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @flabbamann, mind taking a look at this pull request as it has been labeled with an integration ( |
5eba524 to
1f20f26
Compare
balloob
reviewed
Jun 6, 2022
| @@ -96,7 +96,9 @@ class FritzSensorEntityDescription( | |||
| device_class=SensorDeviceClass.VOLTAGE, | |||
| state_class=SensorStateClass.MEASUREMENT, | |||
| suitable=lambda device: device.has_powermeter, # type: ignore[no-any-return] | |||
| native_value=lambda device: device.voltage / 1000 if device.voltage else 0.0, | |||
| native_value=lambda device: device.voltage / 1000 | |||
| if getattr(device, "voltage", None) | |||
There was a problem hiding this comment.
Should you check explicitely for None to guard for device.voltage being 0?
There was a problem hiding this comment.
if there is a value, it must be >0, since the smart plug needs some voltage to work 😄
There was a problem hiding this comment.
regarding style, I think we try to avoid multi-line lambdas but if this is a hotfix maybe it doesn't apply here
balloob
pushed a commit
that referenced
this pull request
Jun 7, 2022
…me (#73141) use default None for device.voltage
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
The property
voltageis not created during init ofFritzDeviceso we need to check if property exists, before trying to access itBased on suggestion from @tobixx in #73018 (comment)
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: