8000 Upgrade glances_api to 0.3.5 by difelice · Pull Request #71243 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Upgrade glances_api to 0.3.5 #71243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 6, 2022
Merged

Upgrade glances_api to 0.3.5 #71243

merged 2 commits into from
May 6, 2022

Conversation

difelice
Copy link
Contributor
@difelice difelice commented May 3, 2022 •
edited
Loading

Breaking change

Proposed change

Dependency Change Log:
https://github.com/home-assistant-ecosystem/python-glances-api/releases/tag/0.3.5

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@homeassistant
Copy link
Contributor

Hi @difelice,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant
Copy link

Hey there @engrbm87, mind taking a look at this pull request as it has been labeled with an integration (glances) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@MartinHjelmare MartinHjelmare changed the title glances: Upgrade glances_api to 0.3.5 Upgrade glances_api to 0.3.5 May 4, 2022
@MartinHjelmare
Copy link
Member

Please read the PR description checklist above and complete the relevant required steps.

@difelice
Copy link
Contributor Author
difelice commented May 4, 2022

Please read the PR description checklist above and complete the relevant required steps.

$ python3 -m script.hassfest
Validating application_credentials... done in 0.15s
Validating codeowners... done in 0.09s
Validating config_flow... done in 0.53s
Validating dependencies... done in 32.43s
Validating dhcp... done in 0.01s
Validating json... done in 0.00s
Validating manifest... done in 0.16s
Validating mqtt... done in 0.00s
Validating requirements... done in 0.03s
Validating services... done in 6.45s
Validating ssdp... done in 0.01s
Validating translations... done in 3.95s
Validating usb... done in 0.00s
Validating zeroconf... done in 0.01s
Validating coverage... done in 0.09s
Validating mypy_config... done in 0.08s
Validating metadata... done in 0.00s

Integrations: 1018
Invalid integrations: 0

Ticked relevant items. I hope it's OK. Thanks.

@difelice
Copy link
Contributor Author
difelice commented May 4, 2022

We may have to wait package to be published: https://pypi.org/project/glances-api/
Circling @fabaff

@MartinHjelmare
Copy link
Member

Please complete the checklist items regarding dependencies and requirements.

@MartinHjelmare MartinHjelmare marked this pull request as draft May 5, 2022 07:01
@MartinHjelmare
Copy link
Member

Please mark as ready for review when the library version is published to PyPI.

@difelice difelice marked this pull request as ready for review May 6, 2022 00:22
@difelice
Copy link
Contributor Author
difelice commented May 6, 2022

Please mark as ready for review when the library version is published to PyPI.

It was published: https://pypi.org/project/glances-api/0.3.5/

Thanks.

MartinHjelmare
MartinHjelmare approved these changes May 6, 2022
View reviewed changes
Copy link
Member
@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare added this to the 2022.5.2 milestone May 6, 2022
@MartinHjelmare MartinHjelmare merged commit 118bae6 into home-assistant:dev May 6, 2022
@difelice
Copy link
Contributor Author
difelice commented May 6, 2022

Thanks!

Thank you for following up. I'll follow PR template carefully next time 🥳

@difelice difelice deleted the patch-1 branch May 6, 2022 12:59
balloob pushed a commit that referenced this pull request May 6, 2022
@difelice @balloob
Upgrade glances_api to 0.3.5 (#71243)
c54e236
@balloob balloob mentioned this pull request May 6, 2022
Merged
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
cherry-picked cla-signed dependency dependency-bump integration: glances small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2022.5.2
Development

Successfully merging this pull request may close these issues.

Since HA 2022.2 upgrade every restart causes loss of all Glances integrations
4 participants
@difelice @homeassistant @MartinHjelmare @balloob
0