8000 Streamline setup of deCONZ scene platform by Kane610 · Pull Request #70700 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Streamline setup of deCONZ scene platform #70700

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 26, 2022
Merged

Streamline setup of deCONZ scene platform #70700

merged 2 commits into from
Apr 26, 2022

Conversation

Kane610
Copy link
Member
@Kane610 Kane610 commented Apr 25, 2022 •
edited
Loading

Breaking change

Proposed change

Utilise the improvements from refactoring pydeconz to stream line platform setup.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Unteste 8000 d files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@Kane610 Kane610 force-pushed the deconz-streamline_scene_setup branch from 53a3734 to e935fb9 Compare April 25, 2022 16:06
@Kane610 Kane610 force-pushed the deconz-streamline_scene_setup branch from 83e903e to f0a6a0b Compare April 25, 2022 19:29
@Kane610 Kane610 mentioned this pull request Apr 25, 2022
Merged
22 tasks
frenck
frenck approved these changes Apr 26, 2022
View reviewed changes
Copy link
Member
@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Kane610 👍

@frenck frenck merged commit f7d9797 into home-assistant:dev Apr 26, 2022
@Kane610 Kane610 deleted the deconz-streamline_scene_setup branch April 26, 2022 11:05
@Kane610
Copy link
Member Author
Kane610 commented Apr 26, 2022

Thank you @frenck 🎉

@Kane610 Kane610 mentioned this pull request Apr 26, 2022
Merged
22 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Apr 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
by-code-owner cla-signed code-quality integration: deconz small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kane610 @frenck @homeassistant
0