Bugfix slider #7047
Merged
Bugfix slider #7047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pvizeli, thanks for your PR! By analyzing the history of the files in this pull request, we identified @persandstrom, @balloob and @kellerza to be potential reviewers. |
balloob
reviewed
Apr 11, 2017
| @@ -175,7 +175,7 @@ def async_added_to_hass(self): | |||
| value = state and float(state.state) | |||
|
|
|||
| # Check against False because value can be 0 | |||
| if value is not False and self._minimum < value < self._maximum: | |||
| if value and self._minimum <= value <= self._maximum: | |||
There was a problem hiding this comment.
On line 175, value is set to False if there is no last state. By not checking against False explicitly we will not restore a state when it's the number 0 (hence the comment above this line).
balloob
pushed a commit
that referenced
this pull request
Apr 11, 2017
* Bugfix slider * Update input_slider.py * Update input_slider.py
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix bug after last change on slider that he can not create without Initial value or restore value.
Related issue (if applicable): fixes #7006 #7044