Plug file leak on LIFX unregister #7031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The aiolifx 0.4.4 release closes its socket when the unregister callback is called. This plugs a file descriptor leak but also means that we must be careful to not use the device after it goes unavailable. Also, when a light reappears, it has a new device that must be used.
pvizeli
reviewed
Apr 11, 2017
| @@ -265,6 +269,9 @@ def async_turn_on(self, **kwargs): | |||
| @asyncio.coroutine | |||
| def async_turn_off(self, **kwargs): | |||
| """Turn the device off.""" | |||
| if not self.available: | |||
| return | |||
|
|
|||
There was a problem hiding this comment.
I'm not sure if that make more sense to use it on Export_entity on ServiceComponent...
There was a problem hiding this comment.
Remove that, I will make a PR for that
There was a problem hiding this comment.
Cool. It was already in async_update before, can I remove it from there as well?
There was a problem hiding this comment.
No update is needed, otherwise the device have no access to come back to available state. On update you need check if the device back to controll or stay available until next update call. But update is only needed on a polling device. If you have a callback and no polling device, you can update the property on callback function.
2 tasks
The core will learn to handle that.
balloob
pushed a commit
that referenced
this pull request
Apr 11, 2017
* Plug file leak on LIFX unregister The aiolifx 0.4.4 release closes its socket when the unregister callback is called. This plugs a file descriptor leak but also means that we must be careful to not use the device after it goes unavailable. Also, when a light reappears, it has a new device that must be used. * Do not test self.available in service calls The core will learn to handle that.
Merged
|
Cherry picked for 0.42.3 |
amelchio
added a commit
to amelchio/home-assistant
that referenced
this pull request
Apr 16, 2017
After home-assistant#7031 the LIFX device will change during an unregister/register transition. This has the user-visible effect of the new device missing a friendly name until the next poll. We now cache the name internally and it will then transfer to the new device when it registers.
balloob
pushed a commit
that referenced
this pull request
Apr 17, 2017
* Cache the name of LIFX lights After #7031 the LIFX device will change during an unregister/register transition. This has the user-visible effect of the new device missing a friendly name until the next poll. We now cache the name internally and it will then transfer to the new device when it registers. * Allow LIFX logging even without an available device This will allow us to set the device to None when it unregisters. * Calculate LIFX availability from the existence of a device This has become possible because the device is no longer needed to provide the name of the light when it is unavailable. We just have to forget the device when it unregisters.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The aiolifx 0.4.4 release closes its socket when the unregister callback is
called. This plugs a file descriptor leak but also means that we must be
careful to not use the device after it goes unavailable.
Also, when a light reappears, it has a new device that must be used.
Related issue (if applicable): fixes #6985
Checklist:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully.requirements_all.txtby runningscript/gen_requirements_all.py.