Added light.pwm component. #7009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@soldag, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @fabaff and @robbiet480 to be potential reviewers. |
fabaff
reviewed
Apr 10, 2017
.coveragerc
Outdated
| @@ -228,6 +228,7 @@ omit = | |||
| homeassistant/components/light/lifx_legacy.py | |||
| homeassistant/components/light/limitlessled.py | |||
| homeassistant/components/light/osramlightify.py | |||
| homeassistant/components/light/pwm.py | |||
There was a problem hiding this comment.
I think that the name is too generic. Prefixing with rpi_gpio would help to identify it as most people will use this platform with a Raspberry Pi.
balloob
approved these changes
Apr 20, 2017
Merged
|
Not sure if that's the good place to comment, but that's great work @soldag , thanks 👍 |
|
@bokub Thank you :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds new light platform to control LEDs connected directly to GPIOs of an Raspberry Pi or to a PCA9685 controller using pwm.
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#2402
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.