8000 Warn if start takes a long time. by balloob · Pull Request #6975 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Warn if start takes a long time. #6975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 8, 2017
Merged

Warn if start takes a long time. #6975

merged 5 commits into from
Apr 8, 2017

Conversation

balloob
Copy link
Member
@balloob balloob commented Apr 7, 2017

Description:

We now wait till all tasks that respond to EVENT_HOMEASSISTANT_START are done. This warning is there to make sure faulty integrations are getting called out.

Log message asks people to report their components/platforms to #6973

Checklist:

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@mention-bot
Copy link

@balloob, thanks for your PR! By analyzing the history of the files in this pull request, we identified @pvizeli, @fabaff and @jaharkes to be potential reviewers.

@balloobbot balloobbot added core and removed cla-signed labels Apr 7, 2017
pvizeli
pvizeli reviewed Apr 7, 2017
View reviewed changes
Copy link
Member
@pvizeli pvizeli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea but not the implementation. My sugestion is that we add a async_timeout (default None) befor we call async_block_till_done in async_stop_track_tasks

@balloob
Copy link
Member Author
balloob commented Apr 8, 2017

I like that even more.

@balloob balloob added this to the 0.42 milestone Apr 8, 2017
@balloob balloob force-pushed the warn-on-never-finishing-start branch from 4c62f89 to 8649efd Compare April 8, 2017 01:53
@balloob balloob merged commit 5d3fe83 into dev Apr 8, 2017
@balloob balloob deleted the warn-on-never-finishing-start branch April 8, 2017 21:53
balloob added a commit that referenced this pull request Apr 8, 2017
@balloob
Warn if start takes a long time. (#6975)
dea9aec 
* Warn if start takes a long time.

* ps - cleanup

* Tweak message

* Add tests

* Tweak messagE
@fabaff fabaff mentioned this pull request Apr 8, 2017
Merged
@balloob balloob mentioned this pull request Apr 21, 2017
Merged
@home-assistant home-assistant locked and limited conversation to collaborators Jul 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pvizeli pvizeli pvizeli left review comments

Assignees
No one assigned
Labels
cla-signed core
Projects
None yet
Milestone
0.42
Development

Successfully merging this pull request may close these issues.
5 participants
@balloob @mention-bot @pvizeli @balloobbot @homeassistant
0