Tests for zwave services #6937
Jump to bottom
8000
Merged
Tests for zwave services #6937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@armills, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @andrey-git and @turbokongen to be potential reviewers. |
houndci-bot
reviewed
Apr 4, 2017
| @@ -554,7 +554,7 @@ def start_zwave(_service_or_event): | |||
| hass.services.register(DOMAIN, const.SERVICE_TEST_NETWORK, | |||
| test_network, | |||
| descriptions[const.SERVICE_TEST_NETWORK]) | |||
| hass.services.register(DOMAIN, const.SERVICE_STOP_NETWORK, stop_zwave, | |||
| hass.services.register(DOMAIN, const.SERVICE_STOP_NETWORK, stop_network, | |||
|
Remove |
|
You can see the progress locally too using py.test --cov --cov-report=term-missing |
|
I wrapped up the rest of the service tests, and I removed zwave init from .coveragerc. Still a lot that needs to be testing, but I figured this gives us a starting point. We can add it back it if we want to wait until more coverage is added. |
|
It drops us from 94% test coverage to 93% 😢 but okay, let's do it but let's make sure we have it up to at least 93.5% before 0.43 ! |
balloob
approved these changes
Apr 7, 2017
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
For #6437
This should wait until after #6813 since it will need to be rebased.