-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
2022.3.5 #68159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: epenet <epenet@users.noreply.github.com>
The base `Cover` entity requires an explicit value for `_attr_is_closed`. Since the `SomfyShade` is an assumed state, we don't know by default whether the shade is open or not, so we need to explicitly return `None` for `_attr_is_closed`
* Bump pyisy to 3.0.4 - Fixes #66003 - Changelog: automicus/PyISY@v3.0.1...v3.0.4 * again
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cla-signed
core
has-tests
merging-to-master
This PR is merging into the master branch and should probably change the branch to `dev`.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None
(@cthornton - #68053) (somfy_mylink docs)