8000 Add discussions sensors to GitHub by timmo001 · Pull Request #66937 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add discussions sensors to GitHub #66937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 20, 2022
Merged

Add discussions sensors to GitHub #66937

merged 4 commits into from
Feb 20, 2022

Conversation

timmo001
Copy link
Contributor

Proposed change

Adds discussion sensors to GitHub integration.

Type of change

  • New feature (which adds functionality to an existing integration)

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@timmo001 timmo001 requested a review from ludeeus as a code owner February 20, 2022 12:27
@probot-home-assistant
Copy link

Hey there @ludeeus, mind taking a look at this pull request as it has been labeled with an integration (github) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

ludeeus
ludeeus approved these changes Feb 20, 2022
View reviewed changes
Copy link
Member
@ludeeus ludeeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than ordering this is identical to a local branch I have 😄
Looks good! 🎉

@ludeeus ludeeus merged commit 5b28e2d into home-assistant:dev Feb 20, 2022
@timmo001 timmo001 deleted the github-discussions branch February 20, 2022 12:32
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ludeeus ludeeus ludeeus approved these changes

Assignees

@ludeeus ludeeus

Labels
by-code-owner cla-signed has-tests integration: github new-feature small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timmo001 @ludeeus @homeassistant
0