8000 Bump amcrest to 1.9.4 by rkben · Pull Request #66124 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bump amcrest to 1.9.4 #66124

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 9, 2022
Merged

Bump amcrest to 1.9.4 #66124

merged 2 commits into from
Feb 9, 2022

Conversation

rkben
Copy link
Contributor
@rkben rkben commented Feb 8, 2022 •
edited
Loading

Breaking change

Proposed change

Bumps python-amcrest to 1.9.4 to close #65652

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@homeassistant
Copy link
Contributor

Hi @rkben,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant
Copy link

Hey there @flacjacket, mind taking a look at this pull request as it has been labeled with an integration (amcrest) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@flacjacket
Copy link
Contributor
flacjacket commented Feb 8, 2022 •
edited
Loading

Can you add a link to the release notes to the "Proposed Change" section?

@rkben
Copy link
Contributor Author
rkben commented Feb 8, 2022

Can you add a link to the release notes to the "Proposed Change" section?

Updated, will that do?

flacjacket
flacjacket approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor
@flacjacket flacjacket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, thanks!

@frenck frenck added this to the 2022.2.5 milestone Feb 9, 2022
frenck
frenck approved these changes Feb 9, 2022
View reviewed changes
Copy link
Member
@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @rkben 👍

@frenck frenck merged commit b90434e into home-assistant:dev Feb 9, 2022
frenck added a commit that referenced this pull request Feb 9, 2022
@rkben @frenck
Bump amcrest to 1.9.4 (#66124)
ae5a885 
Co-authored-by: Franck Nijhof <git@frenck.dev>
@frenck frenck mentioned this pull request Feb 9, 2022
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

@flacjacket flacjacket flacjacket approved these changes

Assignees
No one assigned
Labels
bugfix cherry-picked cla-signed dependency dependency-bump integration: amcrest small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2022.2.5
Development

Successfully merging this pull request may close these issues.

Amcrest integration will not follow redirects
4 participants
@rkben @homeassistant @flacjacket @frenck
0