8000 Fix generic camera typo in attr_frame_interval by davet2001 · Pull Request #65390 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix generic camera typo in attr_frame_interval #65390

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 8, 2022
Merged

Fix generic camera typo in attr_frame_interval #65390

merged 3 commits into from
Feb 8, 2022

Conversation

davet2001
Copy link
Contributor

Breaking change

Proposed change

#63197 introduced a typo.
_attr_frame_interval was wrongly created as _attr_frames_interval.

I can't see anything that has broken yet because of this, but we should fix it, and possibly merge into the new release.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@MartinHjelmare MartinHjelmare added this to the 2022.2.0 milestone Feb 2, 2022
@MartinHjelmare MartinHjelmare changed the title Fix typo in attr_frame_interval Fix generic camera typo in attr_frame_interval Feb 2, 2022
MartinHjelmare
MartinHjelmare reviewed Feb 2, 2022
View reviewed changes
@frenck frenck removed this from the 2022.2.0 milestone Feb 2, 2022
MartinHjelmare
MartinHjelmare reviewed Feb 2, 2022
View reviewed changes
MartinHjelmare
MartinHjelmare approved these changes Feb 8, 2022
View reviewed changes
Copy link
Member
@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@balloob balloob added this to the 2022.2.5 milestone Feb 8, 2022
@balloob balloob merged commit 5ebc02c into home-assistant:dev Feb 8, 2022
@davet2001 davet2001 deleted the fix_generic_frame_interval branch February 8, 2022 23:00
frenck pushed a commit that referenced this pull request Feb 9, 2022
@davet2001 @frenck
Fix generic camera typo in attr_frame_interval (#65390)
f44ca5f
@frenck frenck mentioned this pull request Feb 9, 2022
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
bugfix cherry-picked cla-signed integration: generic small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2022.2.5
Development

Successfully merging this pull request may close these issues.
5 participants
@davet2001 @MartinHjelmare @frenck @balloob @homeassistant
0