8000 Ensure selected entity is pre-selected in homekit options flow by bdraco · Pull Request #63628 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Ensure selected entity is pre-selected in homekit options flow #63628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 8, 2022
Merged

Ensure selected entity is pre-selected in homekit options flow #63628

merged 5 commits into from
Jan 8, 2022

Conversation

bdraco
Copy link
Member
@bdraco bdraco commented Jan 7, 2022

Proposed change

  • We recently adjusted the flow to exclude entities that had
    been deleted from breaking the UI validation. We need to include
    single entities in the set of all supported entities since
    accessory mode has no domain filter

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@bdraco bdraco added this to the 2021.12.9 milestone Jan 7, 2022
@bdraco bdraco marked this pull request as draft January 7, 2022 18:58
@bdraco bdraco marked this pull request as ready for review January 7, 2022 19:16
@bdraco
Copy link
Member Author
bdraco commented Jan 7, 2022

homeassistant/components/homekit/config_flow.py 239 0 100%

bdraco added 5 commits January 7, 2022 11:33
@bdraco
Ensure selected entity is pre-selected in homekit options flow
ec2647f 
- We recently adjusted the flow to exclude entities that had
  been deleted from breaking the UI validation. We need to include
  single entities in the set of all supported entities since
  accessory mode has no domain filter
@bdraco
tweak
c73e60b
@bdraco
Additional fixes
2db240e
@bdraco
small tweak to speed up building the set
e837522
@bdraco
merged fixed version for test branch
88115ef
@bdraco bdraco force-pushed the hk_accessory_mode_fix branch from 3336b85 to 88115ef Compare January 7, 2022 21:34
@bdraco
Copy link
Member Author
bdraco commented Jan 7, 2022

Rebased to see if the codecov issue will clear

@balloob balloob merged commit 9dd09f6 into home-assistant:dev Jan 8, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed has-tests integration: homekit small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2021.12.9
Development

Successfully merging this pull request may close these issues.
3 participants
@bdraco @balloob @homeassistant
0