8000 Bump screenlogicpy by dieselrabbit · Pull Request #63533 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bump screenlogicpy #63533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2022
Merged

Bump screenlogicpy #63533

merged 1 commit into from
Jan 6, 2022

Conversation

dieselrabbit
Copy link
Contributor

Proposed change

Bump screenlogicpy to fix leak of Future objects.
dieselrabbit/screenlogicpy@v0.5.3...v0.5.4

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@dieselrabbit dieselrabbit requested a review from bdraco as a code owner January 6, 2022 08:23
@probot-home-assistant
Copy link

Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration (screenlogic) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@bdraco bdraco added this to the 2021.12.9 milestone Jan 6, 2022
bdraco
bdraco approved these changes Jan 6, 2022
View reviewed changes
Copy link
Member
@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@bdraco
Copy link
Member
bdraco commented Jan 6, 2022

Tested and working. Memory leak appears fix. Will watch it over the next few days as well 👍

@bdraco bdraco merged commit 10e2caf into home-assistant:dev Jan 6, 2022
@dieselrabbit dieselrabbit deleted the screenlogic-futures branch January 6, 2022 08:35
@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bdraco bdraco bdraco approved these changes

Assignees

@bdraco bdraco

Labels
bugfix by-code-owner cherry-picked cla-signed dependency-bump integration: screenlogic small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2021.12.9
Development

Successfully merging this pull request may close these issues.

screenlogicpy appears to have a memory leak of asyncio.Futures
4 participants
@dieselrabbit @bdraco @balloob @homeassistant
0