8000 Add missing migration for Sonos speech enhancement switch entities by jjlawren · Pull Request #63010 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add missing migration for Sonos speech enhancement switch entities #63010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 29, 2021
Merged

Add missing migration for Sonos speech enhancement switch entities #63010

merged 1 commit into from
Dec 29, 2021

Conversation

jjlawren
Copy link
Contributor

Proposed change

In #62691, the unique_id for existing entities was inadvertently changed. This adds a migration step for those that have not yet updated to 2021.12.6.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@jjlawren jjlawren added this to the 2021.12.8 milestone Dec 29, 2021
@jjlawren jjlawren requested a review from cgtobi as a code owner December 29, 2021 16:15
@probot-home-assistant
Copy link

Hey there @cgtobi, mind taking a look at this pull request as it has been labeled with an integration (sonos) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@jjlawren jjlawren mentioned this pull request Dec 29, 2021
Closed
frenck
frenck approved these changes Dec 29, 2021
View reviewed changes
Copy link
Member
@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jjlawren 👍

@frenck frenck modified the milestones: 2021.12.8, 2021.12.7 Dec 29, 2021
@frenck frenck merged commit a8fe9f2 into home-assistant:dev Dec 29, 2021
@jjlawren jjlawren deleted the sonos_migrate_speech_enhancement_entries branch December 29, 2021 16:35
frenck pushed a commit that referenced this pull request Dec 29, 2021
@jjlawren @frenck
Add missing migration for Sonos speech enhancement switch entities (#…
05b2569 
…63010)
@frenck frenck mentioned this pull request Dec 29, 2021
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

@cgtobi cgtobi Awaiting requested review from cgtobi

Assignees

@cgtobi cgtobi

Labels
bugfix by-code-owner cherry-picked cla-signed integration: sonos
Projects
None yet
Milestone
2021.12.7
Development

Successfully merging this pull request may close these issues.
4 participants
@jjlawren @frenck @cgtobi @homeassistant
0