8000 Update xknx to 0.18.14 by farmio · Pull Request #62411 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update xknx to 0.18.14 #62411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 20, 2021
Merged

Update xknx to 0.18.14 #62411

merged 2 commits into from
Dec 20, 2021

Conversation

farmio
Copy link
Contributor
@farmio farmio commented Dec 20, 2021

Proposed change

Update xknx to 0.18.14 - used in the KNX integration

Changelog

May resolve some issues described in #59170 - we'll see.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@farmio farmio requested a review from marvin-w as a code owner December 20, 2021 16:38
@probot-home-assistant
Copy link

Hey there @Julius2342, @marvin-w, mind taking a look at this pull request as it has been labeled with an integration (knx) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@farmio farmio mentioned this pull request Dec 20, 2021
Closed
22 tasks
@frenck frenck added this to the 2021.12.4 milestone Dec 20, 2021
@frenck
Copy link
Member
frenck commented Dec 20, 2021

Rebased to deal with the CI issue

@frenck
Copy link
Member
frenck commented Dec 20, 2021

This was caused by an upstream change in this version:

image

marvin-w
marvin-w approved these changes Dec 20, 2021
View reviewed changes
Copy link
Contributor
@marvin-w marvin-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Results (3.25s):
65 passed

@balloob
Copy link
Member
balloob commented Dec 20, 2021 •
edited
Loading

@marvin-w @farmio may I suggest to only allow keyword arguments for functions and constructors with many parameters. You can force this by using a *:

def bla(*, only, accessible, via, kwargs):
    pass

# Required to invoke function:
bla(only=1, accessible=2, via=3, kwargs=4)

@frenck frenck merged commit 6cf9f1a into home-assistant:dev Dec 20, 2021
@marvin-w
Copy link
Contributor
marvin-w commented Dec 20, 2021 •
edited
Loading

@marvin-w @farmio may I suggest to only allow keyword arguments for functions and constructors with many parameters. You can force this by using a *:

def bla(*, only, accessible, via, kwargs):
    pass

# Required to invoke function:
bla(only=1, accessible=2, via=3, kwargs=4)

Sounds good :)

balloob pushed a commit that referenced this pull request Dec 20, 2021
@farmio @frenck @balloob
Update xknx to 0.18.14 (#62411)
5a2bc8e 
Co-authored-by: Franck Nijhof <git@frenck.dev>
@balloob balloob mentioned this pull request Dec 20, 2021
Merged
@epenet
Copy link
Contributor
epenet commented Dec 20, 2021

@marvin-w @farmio may I suggest to only allow keyword arguments for functions and constructors with many parameters. You can force this by using a *:

You can also keep the compulsory arguments first, and set the * before the optional arguments:

def bla(only, accessible, *, via, kwargs):
    pass

# Required to invoke function:
bla(1, 2, via=3, kwargs=4)

@farmio farmio deleted the xknx-0.18.14 branch December 20, 2021 20:21
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marvin-w marvin-w marvin-w approved these changes

@balloob balloob balloob approved these changes

Assignees

@marvin-w marvin-w

Labels
by-code-owner cherry-picked cla-signed dependency dependency-bump integration: knx small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2021.12.4
Development

Successfully merging this pull request may close these issues.
6 participants
@farmio @frenck @balloob @marvin-w @epenet @homeassistant
0