8000 Fix velbus climate current temp by cereal2nd · Pull Request #62329 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix velbus climate current temp #62329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 19, 2021
Merged

Fix velbus climate current temp #62329

merged 1 commit into from
Dec 19, 2021

Conversation

cereal2nd
Copy link
Contributor
@cereal2nd cereal2nd commented Dec 19, 2021 •
edited
Loading

Proposed change

In one of the last udpates the current temperature was removed from the climate devices, this PR sets back the current_temperature property

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @brefra, mind taking a look at this pull request as it has been labeled with an integration (velbus) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

MartinHjelmare
MartinHjelmare approved these changes Dec 19, 2021
View reviewed changes
Copy link
Member
@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare added this to the 2021.12.4 milestone Dec 19, 2021
@MartinHjelmare MartinHjelmare merged commit 9017d35 into home-assistant:dev Dec 19, 2021
balloob pushed a commit that referenced this pull request Dec 20, 2021
@cereal2nd @balloob
Fix velbus climate current temp (#62329)
7c92577
@balloob balloob mentioned this pull request Dec 20, 2021
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2021
@cereal2nd cereal2nd deleted the velbusclimatefix branch September 26, 2022 12:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed integration: velbus small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2021.12.4
Development

Successfully merging this pull request may close these issues.
4 participants
@cereal2nd @MartinHjelmare @balloob @homeassistant
0