10000 Fix logging for Shelly climate platform by chemelli74 · Pull Request #62264 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix logging for Shelly climate platform #62264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 19, 2021
Merged

Fix logging for Shelly climate platform #62264

merged 3 commits into from
Dec 19, 2021

Conversation

chemelli74
Copy link
Contributor

Proposed change

Fix logging for Shelly climate platform

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @balloob, @bieniu, @thecode, mind taking a look at this pull request as it has been labeled with an integration (shelly) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@chemelli74 chemelli74 added this to the 2021.12.4 milestone Dec 18, 2021
@balloob balloob merged commit 90345b1 into home-assistant:dev Dec 19, 2021
@chemelli74 chemelli74 deleted the chemelli74-shelly-climate-logging branch December 19, 2021 07:55
balloob added a commit that referenced this pull request Dec 20, 2021
@chemelli74 @balloob
Fix logging for Shelly climate platform (#62264)
2395c75 
Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
@balloob balloob mentioned this pull request Dec 20, 2021
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare left review comments

@balloob balloob balloob approved these changes

@bieniu bieniu Awaiting requested review from bieniu bieniu is a code owner

@thecode thecode Awaiting requested review from thecode thecode is a code owner

Assignees

@bieniu bieniu

@balloob balloob

@thecode thecode

Labels
bugfix by-code-owner cherry-picked cla-signed integration: shelly small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2021.12.4
Development

Successfully merging this pull request may close these issues.
6 participants
@chemelli74 @balloob @MartinHjelmare @bieniu @thecode @homeassistant
0